Union support #61
Merged
Union support #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I released aster 0.28.0 containing your union and array builders. |
|
Thanks! This is ready for review then. r? @nox |
|
Looks good! Just squash what should be squashed, otherwise r=me. |
|
@bors-servo: r=nox |
|
📌 Commit 9e1ddf9 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Sep 23, 2016
Union support Built on top of #58, this adds support for untagged unions if not running under the `--no-unstable-rust-flag`. The last commit is an example try run passing with this, but should be reverted (and the `--no-unstable-rust` flag passed by default to our harness). This depends on serde-deprecated/aster#109. r? @nox
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #58, this adds support for untagged unions if not running under the
--no-unstable-rust-flag.The last commit is an example try run passing with this, but should be reverted (and the
--no-unstable-rustflag passed by default to our harness).This depends on serde-deprecated/aster#109.
r? @nox