-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize the crate and rename to bindgen. #414
Conversation
cc @Yamakaky |
You should change the version to 0.20, so that it's considered an upgrade on crates.io. Seems good otherwise. |
Good catch @Yamakaky :) |
☔ The latest upstream changes (presumably #413) made this pull request unmergeable. Please resolve the merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! One nitpick below, after that r=me.
@@ -117,20 +117,20 @@ In `Cargo.toml`: | |||
build = "build.rs" | |||
|
|||
[build-dependencies] | |||
libbindgen = "0.1" | |||
bindgen = "0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably suggest "0.20" now right?
I'll need to update my tutorial now :) |
@bors-servo r=fitzgen,Yamakaky Yay! |
📌 Commit aad93a8 has been approved by |
☀️ Test successful - status-travis |
@emilio did you publish a new version to crates.io? |
Yup!
…On Mon, Jan 23, 2017 at 08:15:08AM -0800, Nick Fitzgerald wrote:
@emilio did you publish a new version to crates.io?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#414 (comment)
|
Fixes #398
Fixes #21
r? @fitzgen