Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize the crate and rename to bindgen. #414

Merged
merged 2 commits into from
Jan 23, 2017

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Jan 22, 2017

Fixes #398
Fixes #21

r? @fitzgen

@emilio
Copy link
Contributor Author

emilio commented Jan 22, 2017

cc @Yamakaky

@Yamakaky
Copy link
Contributor

Yamakaky commented Jan 22, 2017

You should change the version to 0.20, so that it's considered an upgrade on crates.io. Seems good otherwise.

@emilio
Copy link
Contributor Author

emilio commented Jan 22, 2017

Good catch @Yamakaky :)

@bors-servo
Copy link

☔ The latest upstream changes (presumably #413) made this pull request unmergeable. Please resolve the merge conflicts.

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! One nitpick below, after that r=me.

@@ -117,20 +117,20 @@ In `Cargo.toml`:
build = "build.rs"

[build-dependencies]
libbindgen = "0.1"
bindgen = "0.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably suggest "0.20" now right?

@fitzgen
Copy link
Member

fitzgen commented Jan 23, 2017

I'll need to update my tutorial now :)

@emilio
Copy link
Contributor Author

emilio commented Jan 23, 2017

@bors-servo r=fitzgen,Yamakaky

Yay!

@bors-servo
Copy link

📌 Commit aad93a8 has been approved by fitzgen,Yamakaky

@bors-servo
Copy link

⌛ Testing commit aad93a8 with merge ab6117c...

bors-servo pushed a commit that referenced this pull request Jan 23, 2017
Reorganize the crate and rename to bindgen.

Fixes #398
Fixes #21

r? @fitzgen
@bors-servo
Copy link

☀️ Test successful - status-travis

@fitzgen
Copy link
Member

fitzgen commented Jan 23, 2017

@emilio did you publish a new version to crates.io?

@emilio
Copy link
Contributor Author

emilio commented Jan 23, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants