Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the is_invalid_named_type function. #460

Closed
emilio opened this issue Jan 30, 2017 · 2 comments
Closed

Test the is_invalid_named_type function. #460

emilio opened this issue Jan 30, 2017 · 2 comments

Comments

@emilio
Copy link
Contributor

emilio commented Jan 30, 2017

In #384 I landed a is_invalid_named_type function.

We should add tests to ensure it doesn't mess it up, it'd be helpful to have a few unit tests or doctests for it.

An example of such a test would look like:

let ty = Type::new(Some("foo".into()), None, TypeKind::Named, false);
assert!(!ty.is_invalid_named_type())
@emilio emilio added the E-easy label Jan 30, 2017
@highfive
Copy link

Please make a comment here if you intend to work on this issue. Thank you!

manuel-woelker added a commit to manuel-woelker/rust-bindgen that referenced this issue Feb 7, 2017
bors-servo pushed a commit that referenced this issue Feb 8, 2017
ty: add tests for Type.is_invalid_named_type() (#460)

I didn't add an extra test module, since I couldn't find any precedents in the project.

Feedback welcome!
@fitzgen
Copy link
Member

fitzgen commented Feb 10, 2017

Fixed in cedadf9

@fitzgen fitzgen closed this as completed Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants