Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect use of deprecated attribute #1475

Closed
estebank opened this issue Dec 27, 2018 · 1 comment
Closed

Incorrect use of deprecated attribute #1475

estebank opened this issue Dec 27, 2018 · 1 comment

Comments

@estebank
Copy link

rust-lang/rust#56896 is making the correct use of deprecated mandatory in rustc. We can't apply this as a hard error due to the following use in bindgen:

[INFO] [stderr]     Checking bindgen v0.32.3
[INFO] [stderr] error: expected meta item sequence
[INFO] [stderr]    --> /opt/crater/cargo-home/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/bindgen-0.32.3/src/lib.rs:677:5
[INFO] [stderr]     |
[INFO] [stderr] 677 |     #[deprecated = "Use blacklist_type instead"]
[INFO] [stderr]     |     ^^-----------------------------------------^
[INFO] [stderr]     |       |
[INFO] [stderr]     |       help: use the `note` key: `deprecated(note = "Use blacklist_type instead")`
[INFO] [stderr] 
[INFO] [stderr] error: expected meta item sequence
[INFO] [stderr]    --> /opt/crater/cargo-home/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/bindgen-0.32.3/src/lib.rs:699:5
[INFO] [stderr]     |
[INFO] [stderr] 699 |     #[deprecated = "use whitelist_type instead"]
[INFO] [stderr]     |     ^^-----------------------------------------^
[INFO] [stderr]     |       |
[INFO] [stderr]     |       help: use the `note` key: `deprecated(note = "use whitelist_type instead")`
[INFO] [stderr] 
[INFO] [stderr] error: expected meta item sequence
[INFO] [stderr]    --> /opt/crater/cargo-home/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/bindgen-0.32.3/src/lib.rs:723:5
[INFO] [stderr]     |
[INFO] [stderr] 723 |     #[deprecated = "use whitelist_function instead"]
[INFO] [stderr]     |     ^^---------------------------------------------^
[INFO] [stderr]     |       |
[INFO] [stderr]     |       help: use the `note` key: `deprecated(note = "use whitelist_function instead")`
[INFO] [stderr] 
[INFO] [stderr] error: expected meta item sequence
[INFO] [stderr]    --> /opt/crater/cargo-home/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/bindgen-0.32.3/src/lib.rs:739:5
[INFO] [stderr]     |
[INFO] [stderr] 739 |     #[deprecated = "use whitelist_var instead"]
[INFO] [stderr]     |     ^^----------------------------------------^
[INFO] [stderr]     |       |
[INFO] [stderr]     |       help: use the `note` key: `deprecated(note = "use whitelist_var instead")`
@emilio
Copy link
Contributor

emilio commented Dec 27, 2018

This is fixed in trunk a while ago already, so IIUC what needs to happen is to update bindgen on the wild.

Let me know if I misunderstood. I'm happy to help unblock people if they cannot update to newer versions for any particular reason.

@emilio emilio closed this as completed Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants