Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP: Return appropriate markdown content #4326

Open
kjeremy opened this issue May 5, 2020 · 2 comments
Open

LSP: Return appropriate markdown content #4326

kjeremy opened this issue May 5, 2020 · 2 comments
Labels
A-lsp LSP conformance issues and missing features S-actionable Someone could pick this issue up and work on it right now

Comments

@kjeremy
Copy link
Contributor

kjeremy commented May 5, 2020

If HoverClientCapabilities.contentFormat or CompletionClientCapabilities.completionItem.documentationFormat or SignatureHelpClientCapabilities.signatureInformation.documentationFormat are absent then we need to return:

Request Return
Hover MarkedString
Completion string
SignatureHelp string

See: https://microsoft.github.io/language-server-protocol/specifications/specification-3-16/#textDocument_hover
@kjeremy
Copy link
Contributor Author

kjeremy commented Jun 18, 2020

This is part of #144

@kjeremy
Copy link
Contributor Author

kjeremy commented Jun 19, 2020

User report in the wild: https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/MarkupKind/near/201324222

@kjeremy kjeremy mentioned this issue Sep 16, 2020
Closed
@kjeremy kjeremy mentioned this issue Oct 5, 2020
Merged
@lnicola lnicola added the S-actionable Someone could pick this issue up and work on it right now label Jan 22, 2021
@kjeremy kjeremy mentioned this issue Mar 2, 2021
Merged
@Veykril Veykril added the A-lsp LSP conformance issues and missing features label May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lsp LSP conformance issues and missing features S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lnicola @Veykril @kjeremy