Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goto declaration on assoc items of trait implementation should go to the assoc item of the trait #13599

Closed
Veykril opened this issue Nov 10, 2022 · 0 comments · Fixed by #13671
Labels
A-ide general IDE features C-feature Category: feature request

Comments

@Veykril
Copy link
Member

Veykril commented Nov 10, 2022

Right now, goto definition goes to the assoc item of the trait impl while goto declaration does nothing. Usually declaration and definition are the same thing in rust, but in this case the trait assoc item feels like a decleration to me, and so I think for goto declaration we should actually go to the trait instead of the implementation.

@Veykril Veykril added C-feature Category: feature request A-ide general IDE features labels Nov 10, 2022
@bors bors closed this as completed in 99daf23 Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ide general IDE features C-feature Category: feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant