Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Inverse of qualify_method_call #12497

Closed
kpozin opened this issue Jun 9, 2022 · 5 comments
Closed

Feature Request: Inverse of qualify_method_call #12497

kpozin opened this issue Jun 9, 2022 · 5 comments
Labels

Comments

@kpozin
Copy link

kpozin commented Jun 9, 2022

Sometimes you realize that a fully qualified function call is no longer ambiguous and could be made into a method call instead. A code assist for this change would be helpful.

@sancho20021
Copy link
Contributor

Does this assist need to make sure the call isn't ambiguous?
Where should the cursor be located when suggesting the assist, at the function identifier?

@Veykril
Copy link
Member

Veykril commented Aug 17, 2022

Ye I think showing this when its ambiguous is rather pointless so the assist should check that.
I'd say the function identifier is a good choice ye

@sancho20021
Copy link
Contributor

sancho20021 commented Aug 17, 2022

Ok, I will try to do this.
Update: I stopped, so everyone don't hesitate on taking this issue)

@flodiebold
Copy link
Member

I would start by implementing it without the check though, I think this would still be useful without it.

@DropDemBits
Copy link
Contributor

I think #13825 implements this assist, so I think this can be closed now?

@lnicola lnicola closed this as completed Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants