Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trait Signature help with assoc types highlights incorrectly #12270

Closed
Veykril opened this issue May 16, 2022 · 1 comment · Fixed by #12272
Closed

Trait Signature help with assoc types highlights incorrectly #12270

Veykril opened this issue May 16, 2022 · 1 comment · Fixed by #12272
Assignees
@jonas-schievink
Labels
A-ide general IDE features C-bug Category: bug

Comments

@Veykril
Copy link
Member

Veykril commented May 16, 2022

image
@Veykril Veykril added C-bug Category: bug A-ide general IDE features labels May 16, 2022
@jonas-schievink
Copy link
Contributor

Ah, the LSP offsets are in UTF-16 units, not bytes

@jonas-schievink jonas-schievink self-assigned this May 16, 2022
@jonas-schievink jonas-schievink mentioned this issue May 16, 2022
Merged
@bors bors closed this as completed in 7959307 May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonas-schievink jonas-schievink

Labels
A-ide general IDE features C-bug Category: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix signature help LSP offset conversion
2 participants
@jonas-schievink @Veykril