Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Ease transition into using workspace mode by default #602

Closed
Xanewok opened this issue Nov 28, 2017 · 1 comment
Closed

Ease transition into using workspace mode by default #602

Xanewok opened this issue Nov 28, 2017 · 1 comment

Comments

@Xanewok
Copy link
Member

Xanewok commented Nov 28, 2017

To make the transition easier, it'd be good to inform user that they opened a workspace, yet still use "workspace_mode": false. Previously it just crashed, corrupting RLS (#598).

I believe a good solution would be to allow builds to return messages that will be displayed for the user. One example might be an information: "Attempted to perform a single-package build inside a Cargo workspace. Consider turning "workspace_mode" option on." to explain users why the code doesn't work and what to do to fix this.
Another use would be to inform user that rustc has encountered an ICE and thus won't give any meaningful diagnostics. Currently this is only shown in RLS' stderr and rls-vscode happily displays RLS Analysis: Done misleading users.

One small step to simplify the BuildResult variant to further contains also notifications is #601.

cc #132

@Xanewok
Copy link
Member Author

Xanewok commented Jan 12, 2018

In general returning notifications from build might be something we can consider, but currently workspace mode is on by default, so it's not needed now.

@Xanewok Xanewok closed this as completed Jan 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant