Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Format ranges #333

Closed
nrc opened this issue May 29, 2017 · 2 comments
Closed

Format ranges #333

nrc opened this issue May 29, 2017 · 2 comments
Labels
good first issue P-high

Comments

@nrc
Copy link
Member

nrc commented May 29, 2017 •
edited
Loading

We currently only format a whole file. We should also try to format a range. Rustfmt has partial support for this (rust-lang/rustfmt#1159) I think it is good enough, that we should implement in the RLS (as an unstable feature) and then let Rustfmt catch up.
@nrc nrc mentioned this issue May 29, 2017
Closed
9 tasks
@kogai
Copy link
Contributor

kogai commented Jun 10, 2017

I want to challenge this.
Probably, I start from reading ActionHandler.reformat.

@nrc
Copy link
Member Author

nrc commented Jun 10, 2017

@kogai yes, it should look pretty similar to reformat. In Rustfmt, you'll want to look at the "file-lines" feature which lets you pass the range to Rustfmt.

@kogai kogai mentioned this issue Jun 13, 2017
Merged
@nrc nrc closed this as completed Jun 20, 2017
@Avi-D-coder Avi-D-coder mentioned this issue Jul 16, 2017
Closed
@nrc nrc mentioned this issue Jan 10, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue P-high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nrc @kogai