Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

RLS is causing a memory leak on Linux atom/vscode native file watcher #1469

Closed
alexheretic opened this issue Jun 1, 2019 · 4 comments
Closed

Comments

@alexheretic
Copy link
Member

RLS target data generation causes memory leak in nsfw file watchers on Linux.

This issue will affect Linux Atom & probably Vscode users too as they both make use of the nsfw native file watching project. It causes ide memory to leak, and in some cases will consume all system memory.

This can be reproduced by simply running Atom along with rls --cli in a terminal, particularly with the 1.35 release. Interestingly the leak does not occur by simply running/re-running cargo directly, but running rls --cli it can be quickly observed.

Investigation done in: rust-lang/atom-ide-rust#104
Related: atom/nsfw#7, Axosoft/nsfw#72

@Denommus
Copy link

Denommus commented Jun 7, 2019

Also happening to me on Emacs.

@alexheretic
Copy link
Member Author

To be clear this issue isn't rls itself leaking, though rls does have its own memory issues.

@youssefhabri
Copy link

I have experienced this on both neovim & vscode. And this was happening on a project with only 2 files.

@alexheretic
Copy link
Member Author

The upstream file-watcher has fixed a Linux string allocation leak and this seems to address the memory issues with rls usage. I'll close this now, more general rls memory issues on linux are covered by #1188

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants