-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Item grouping #849
RFC: Item grouping #849
Conversation
|
||
```rust | ||
#[cfg(target_os = "windows")] | ||
impl { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this not just be mod imp { }
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes it can, but sometimes you have a different set of items available on each platform. In that case you need a glob pub use
or some cfg
'd pub use
s.
It feels wrong to use |
This would be a really nice feature but I think I agree with @sfackler here. |
This is an interesting idea, but not critical for 1.0. It also sounds like there may be some better syntactic choices... I am postponing this, but I hope the discussion might continue on the postponed issue: #931 (or perhaps in an |
Simply having scoped |
cc #2377 |
Rendered