Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating links for accepted RFCs #2183

Closed
ExpHP opened this issue Oct 20, 2017 · 3 comments
Closed

Updating links for accepted RFCs #2183

ExpHP opened this issue Oct 20, 2017 · 3 comments
Labels
T-core Relevant to the core team, which will review and decide on the RFC.

Comments

@ExpHP
Copy link

ExpHP commented Oct 20, 2017

The hardest time to locate the text of an RFC is after it gets merged.

Here's what happens:

  • The rendered markdown link in the top post invariably points to the author's fork, because that's where the file originally existed.
  • RFC gets merged.
  • A tracking issue gets created which invariably contains a link to the pull request, but no link to the rendered text.
  • Github presents the author with a shiny button to delete their useless branch.
  • Author clicks the button. 🍹 Ahhh, refreshing.
  • Rendered link is now broken.

Not having found myself on the other side of the "merge" coin all too often, I'm not certain, do the repo maintainers have the ability to edit the PR text and fix the link when they merge? Can this be part of the process?

(Or alternatively, make it a point to put these links in tracking issues?)

@nagisa
Copy link
Member

nagisa commented Oct 20, 2017 via email

@scottmcm
Copy link
Member

I made updating the rendered link part of the process in rust-lang/rust-forge#105.

@ExpHP
Copy link
Author

ExpHP commented Oct 25, 2017

Ah, thanks! I shall close this.

@ExpHP ExpHP closed this as completed Oct 25, 2017
@Centril Centril added the T-core Relevant to the core team, which will review and decide on the RFC. label Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-core Relevant to the core team, which will review and decide on the RFC.
Projects
None yet
Development

No branches or pull requests

4 participants