Apply Clippy lints #516

hellow554 · 2022-05-31T12:24:27Z

This is similar to #511 but adds a clippy.toml to tell the msrv which prevents features to be pulled in that are not released in that version.

Also add a github worflow for clippy

hellow554 · 2022-05-31T12:27:36Z

src/lib.rs

@@ -653,88 +585,18 @@ pub enum LevelFilter {
    Trace,
 }

-// Deriving generates terrible impls of these traits


This statement is not right. I created a godbolt for it. There's no real difference between derived impls and custom impls (anymore): https://rust.godbolt.org/z/7K1vjG6KE

KodrAus

Thanks @hellow554! I didn't know about clippy.toml 👀 That's great to know. I just had one comment, which doesn't actually affect the code you've fixed, but otherwise this looks good to me.

src/kv/key.rs

Co-authored-by: Ashley Mannix <[email protected]>

hellow554 · 2022-06-01T05:49:41Z

Done :)

Thomasdezeeuw · 2022-06-01T08:48:33Z

src/lib.rs

@@ -1546,7 +1420,7 @@ impl error::Error for SetLoggerError {}
 ///
 /// [`from_str`]: https://doc.rust-lang.org/std/str/trait.FromStr.html#tymethod.from_str
 #[allow(missing_copy_implementations)]
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Eq)]


Functional/API change, but personally I'm ok with it.

Clippy suggested it and I thought it made sense.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [log](https://github.com/rust-lang/log) | dependencies | patch | `0.4.17` -> `0.4.19` | --- ### Release Notes <details> <summary>rust-lang/log</summary> ### [`v0.4.19`](https://github.com/rust-lang/log/blob/HEAD/CHANGELOG.md#0419---2023-06-10) [Compare Source](rust-lang/log@0.4.18...0.4.19) - Use target_has_atomic instead of the old atomic_cas cfg by [@GuillaumeGomez](https://github.com/GuillaumeGomez) in rust-lang/log#555 - Put MSRV into Cargo.toml by [@est31](https://github.com/est31) in rust-lang/log#557 ### [`v0.4.18`](https://github.com/rust-lang/log/blob/HEAD/CHANGELOG.md#0418---2023-05-28) [Compare Source](rust-lang/log@0.4.17...0.4.18) - fix markdown links (again) by [@hellow554](https://github.com/hellow554) in rust-lang/log#513 - add cargo doc to workflow by [@hellow554](https://github.com/hellow554) in rust-lang/log#515 - Apply Clippy lints by [@hellow554](https://github.com/hellow554) in rust-lang/log#516 - Replace ad-hoc eq_ignore_ascii_case with slice::eq_ignore_ascii_case by [@glandium](https://github.com/glandium) in rust-lang/log#519 - fix up windows targets by [@KodrAus](https://github.com/KodrAus) in rust-lang/log#528 - typo fix by [@jiangying000](https://github.com/jiangying000) in rust-lang/log#529 - Remove dependency on cfg_if by [@EriKWDev](https://github.com/EriKWDev) in rust-lang/log#536 - GitHub Workflows security hardening by [@sashashura](https://github.com/sashashura) in rust-lang/log#538 - Fix build status badge by [@atouchet](https://github.com/atouchet) in rust-lang/log#539 - Add call_logger to the documentation by [@a1ecbr0wn](https://github.com/a1ecbr0wn) in rust-lang/log#547 - Use stable internals for key-value API by [@KodrAus](https://github.com/KodrAus) in rust-lang/log#550 - Change wording of list of implementations by [@Thomasdezeeuw](https://github.com/Thomasdezeeuw) in rust-lang/log#553 - Add std-logger to list of implementations by [@Thomasdezeeuw](https://github.com/Thomasdezeeuw) in rust-lang/log#554 - Add `set_max_level_racy` and gate `set_max_level` by [@djkoloski](https://github.com/djkoloski) in rust-lang/log#544 - \[doc] src/lib.rs : prefix an unused variable with an underscore by [@OccupyMars2025](https://github.com/OccupyMars2025) in rust-lang/log#561 - \[doc] src/macros.rs : correct grammar errors of an example in lib documentation by [@OccupyMars2025](https://github.com/OccupyMars2025) in rust-lang/log#562 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1911 Reviewed-by: crapStone <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>

Bumps [clap](https://github.com/clap-rs/clap) from 4.0.18 to 4.0.22. - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](clap-rs/clap@v4.0.18...v4.0.22) --- updated-dependencies: - dependency-name: clap dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

hellow554 added 3 commits May 31, 2022 14:05

add clippy toml with msrv = 1.31

0521b3f

apply clippy lints

4b52024

add clippy to github workflow

b4a064c

hellow554 commented May 31, 2022

View reviewed changes

KodrAus reviewed May 31, 2022

View reviewed changes

src/kv/key.rs Show resolved Hide resolved

clarify comment about derive impls

e68fa19

Co-authored-by: Ashley Mannix <[email protected]>

Thomasdezeeuw approved these changes Jun 1, 2022

View reviewed changes

Merge branch 'master' into clippy_lints

d9f0939

KodrAus merged commit ca62c39 into rust-lang:master Jun 2, 2022

KodrAus mentioned this pull request Apr 11, 2023

Prepare for 0.4.19 release #552

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Apply Clippy lints #516

Apply Clippy lints #516

hellow554 commented May 31, 2022 •

edited

Loading

hellow554 May 31, 2022

KodrAus left a comment

hellow554 commented Jun 1, 2022

Thomasdezeeuw Jun 1, 2022

hellow554 Jun 1, 2022

Apply Clippy lints #516

Apply Clippy lints #516

Conversation

hellow554 commented May 31, 2022 • edited Loading

hellow554 May 31, 2022

Choose a reason for hiding this comment

KodrAus left a comment

Choose a reason for hiding this comment

hellow554 commented Jun 1, 2022

Thomasdezeeuw Jun 1, 2022

Choose a reason for hiding this comment

hellow554 Jun 1, 2022

Choose a reason for hiding this comment

hellow554 commented May 31, 2022 •

edited

Loading