Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Are these #[inline] helping? #92

Closed
dpc opened this issue Aug 3, 2016 · 1 comment
Closed

Are these #[inline] helping? #92

dpc opened this issue Aug 3, 2016 · 1 comment

Comments

@dpc
Copy link

dpc commented Aug 3, 2016

I've noticed that log crate goes out of it's way to add #[inline] in a lot of places. I'd like to ask - is it worth it with a current rust compiler? Any experiences and measurements?

Corresponding slog-rs issue: slog-rs/slog#25
@dtolnay
Copy link
Member

dtolnay commented Aug 17, 2018

Here is the latest wisdom about #[inline]: rust-lang/rust#52704 (comment).

@KodrAus KodrAus closed this as completed Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dpc @dtolnay @KodrAus