Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add killpg #879

Merged
merged 1 commit into from
Jan 13, 2018
Merged

Add killpg #879

merged 1 commit into from
Jan 13, 2018

Conversation

SanchayanMaity
Copy link
Contributor

No description provided.

@alexcrichton
Copy link
Member

Thanks! Looks like this may have a different name on 32-bit OSX?

@SanchayanMaity
Copy link
Contributor Author

@alexcrichton Do I need to put a cfg_attr to prevent this from being exposed on i686 darwin?

@alexcrichton
Copy link
Member

That could work, although it may just need a different link_name perhaps? There's a few other examples of doing this in unix/mod.rs which may indicate what the name should be?

@marioidival
Copy link
Member

@alexcrichton this PR can be merged?

@alexcrichton
Copy link
Member

@bors: r+

Indeed! Sorry for the delay!

@bors
Copy link
Contributor

bors commented Jan 13, 2018

📌 Commit a2f948d has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jan 13, 2018

⌛ Testing commit a2f948d with merge 3ccb075...

bors added a commit that referenced this pull request Jan 13, 2018
@bors
Copy link
Contributor

bors commented Jan 13, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 3ccb075 to master...

@bors bors merged commit a2f948d into rust-lang:master Jan 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants