Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mach_error_string (and mach_error_t) #3913

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

stepancheg
Copy link
Contributor

@stepancheg stepancheg commented Sep 10, 2024

mach_error_string is defined in /usr/include/mach/mach_error.h
It is not referenced in the documentation Apple website.

char            *mach_error_string(
/*
 *  Returns a string appropriate to the error argument given
 */
    mach_error_t error_value
    );

mach_error_t is defined in /usr/include/mach/error.h
https://developer.apple.com/documentation/kernel/mach_error_t

typedef kern_return_t   mach_error_t;

@rustbot
Copy link
Collaborator

rustbot commented Sep 10, 2024

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35
Copy link
Contributor

tgross35 commented Oct 1, 2024

Thanks for the PR, could you update the description with links to the headers and/or docs?

`mach_error_string` is defined in `/usr/include/mach/mach_error.h`
It is not referenced in the documentation Apple website.

```
char            *mach_error_string(
/*
 *  Returns a string appropriate to the error argument given
 */
    mach_error_t error_value
    );
```

`mach_error_t` is defined in `/usr/include/mach/error.h`
https://developer.apple.com/documentation/kernel/mach_error_t

```
typedef kern_return_t   mach_error_t;
```
@stepancheg
Copy link
Contributor Author

Done.

@tgross35
Copy link
Contributor

tgross35 commented Oct 1, 2024

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Oct 1, 2024
@tgross35 tgross35 added this pull request to the merge queue Oct 1, 2024
Merged via the queue into rust-lang:main with commit d8ff07b Oct 1, 2024
41 checks passed
@tgross35 tgross35 mentioned this pull request Oct 15, 2024
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Oct 15, 2024
`mach_error_string` is defined in `/usr/include/mach/mach_error.h`
It is not referenced in the documentation Apple website.

```
char            *mach_error_string(
/*
 *  Returns a string appropriate to the error argument given
 */
    mach_error_t error_value
    );
```

`mach_error_t` is defined in `/usr/include/mach/error.h`
https://developer.apple.com/documentation/kernel/mach_error_t

```
typedef kern_return_t   mach_error_t;
```

(backport <rust-lang#3913>)
(cherry picked from commit d8ff07b)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants