Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build job for Rust 1.30 version compatibility #1138

Closed
wants to merge 1 commit into from
Closed

Add build job for Rust 1.30 version compatibility #1138

wants to merge 1 commit into from

Conversation

gnzlbg
Copy link
Contributor

@gnzlbg gnzlbg commented Nov 22, 2018

From that version on we use core::ffi::c_void instead of our own c_void.

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@gnzlbg gnzlbg mentioned this pull request Nov 22, 2018
Closed
@alexcrichton
Copy link
Member

Is this still needed?

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 22, 2018

No, I thought this was going to break CI, but it didn't. See #1136 .

@gnzlbg gnzlbg closed this Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gnzlbg @rust-highfive @alexcrichton