-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rumprun CI #76
Comments
Yes, I would like to see that as well. Note that the new version (0.2) of the libc crate doesn't contain the Rumprun patches from rust-lang/rust#28543. I haven't found the time to port them yet. Since Rumprun uses NetBSD's libc (and the libc crate shares all the code), testing Rumprun also means testing NetBSD and vice versa. Therefore, I also see two alternatives to running a Rumprun binary inside qemu:
|
I would love to see this happen. @gandro I did submit patches to get rumprun running at some point... or maybe it was just fixing the build on stable rust so a release could get cut. Hm. |
AFAIR that was for the last v0.1.x release. The NetBSD/Rumprun changes never ended up in the refactored (v0.2.0) version of this crate, since my patches landed around the same time RFC1291 was proposed. But no worries, I started working on re-adding NetBSD/Rumprun support for the libc crate and will issue a PR, but I ran out of time for today.
I'm wondering if we somehow could also provide these pre-compiled target libraries to all users, since building Rust for Rumprun is quite a hassle (especially on OS X). Are there dedicated buildbots for such things? I would gladly help out. |
We don't currently have dedicated bots for building rumprun (like we're building arm/mips linux today), but I'd be willing to set some up! Other than that we can just build one set of libraries and pin to a nightly version of Rust for CI in libc. I actually explored this over the thanksgiving break and I have a branch with rumprun CI but I'd like to re-verify definitions on OpenBSD, NetBSD, and ideally Bitrig before merging as lots of movement happened. |
Added in #86 |
It looks like the rumprun target for the compiler is pretty cool, can we add CI for it to make sure the bindings here are correct? There's a few steps to this:
cc @gandro
The text was updated successfully, but these errors were encountered: