Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit allow(...)ed lints #4141

Open
tgross35 opened this issue Nov 25, 2024 · 1 comment
Open

Revisit allow(...)ed lints #4141

tgross35 opened this issue Nov 25, 2024 · 1 comment
Milestone

Comments

@tgross35
Copy link
Contributor

In particular, overflowing_literals would have caught #3584. We might be okay getting rid of a few of these

libc/src/lib.rs

Lines 5 to 18 in aff3132

renamed_and_removed_lints, // Keep this order.
unknown_lints, // Keep this order.
bad_style,
overflowing_literals,
improper_ctypes,
// This lint is renamed but we run CI for old stable rustc so should be here.
redundant_semicolon,
redundant_semicolons,
unused_macros,
unused_macro_rules,
// FIXME: temporarily allow dead_code to fix CI:
// - https://github.com/rust-lang/libc/issues/3740
// - https://github.com/rust-lang/rust/pull/126456
dead_code,
.

@tgross35 tgross35 added this to the 1.0 milestone Nov 25, 2024
@tgross35
Copy link
Contributor Author

On that note: we should make sure to separate flags intended for clone vs. anything that goes into clone_args for clone3, which uses 64-bit flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant