Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only instantiate RawTable's reserve functions once #204

Merged
merged 4 commits into from
Sep 30, 2020
Merged

fix: Only instantiate RawTable's reserve functions once #204

merged 4 commits into from
Sep 30, 2020

Commits on Sep 29, 2020

  1. fix: Only instantiate RawTable's reserve functions once 

    ...per key-value.

Each of the previous closures would cause an entirely new reserve/resize
function to be instantiated. By using this trick (which std uses for
iterator adaptors), we always get a single instantiatiation per key
(modulo the insert_with_hasher method).
    Markus Westerlind committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    b7830cf View commit details
    Browse the repository at this point in the history

  2. Don't instantiate get functions twice either

    Markus Westerlind committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    63832ed View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2020

  1. Address review comments

    Markus Westerlind committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    d8463d0 View commit details
    Browse the repository at this point in the history

  2. nits

    Markus Westerlind committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    5e11d32 View commit details
    Browse the repository at this point in the history