Fix CI failure #2829

taiki-e · 2024-02-25T08:48:42Z

No description provided.

``` error: the item `Box` is imported redundantly --> futures-core/src/future.rs:89:9 | 89 | use alloc::boxed::Box; | ^^^^^^^^^^^^^^^^^ --> /rustc/381d69953bb7c3390cec0fee200f24529cb6320f/library/std/src/prelude/mod.rs:115:13 | = note: the item `Box` is already defined here | = note: `-D unused-imports` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_imports)]` error: the item `Box` is imported redundantly --> futures-core/src/stream.rs:203:9 | 203 | use alloc::boxed::Box; | ^^^^^^^^^^^^^^^^^ --> /rustc/381d69953bb7c3390cec0fee200f24529cb6320f/library/std/src/prelude/mod.rs:115:13 | = note: the item `Box` is already defined here ```

``` warning: trait `AssertSync` is never used --> futures-core/src/task/__internal/atomic_waker.rs:209:15 | 209 | trait AssertSync: Sync {} | ^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default warning: trait `AssertKinds` is never used --> futures-channel/src/mpsc/mod.rs:130:7 | 130 | trait AssertKinds: Send + Sync + Clone {} | ^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default warning: trait `AssertSendSync` is never used --> futures-executor/src/thread_pool.rs:48:7 | 48 | trait AssertSendSync: Send + Sync {} | ^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default warning: trait `AssertSend` is never used --> futures-channel/tests/mpsc.rs:13:7 | 13 | trait AssertSend: Send {} | ^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default ```

``` error: redundant explicit link target --> futures-executor/src/local_pool.rs:314:25 | 314 | /// Use a [`LocalPool`](LocalPool) if you need finer-grained control over | ----------- ^^^^^^^^^ explicit target is redundant | | | because label contains path that resolves to same destination | = note: when a link's destination is not specified, the label is used to resolve intra-doc links = note: `-D rustdoc::redundant-explicit-links` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(rustdoc::redundant_explicit_links)]` help: remove explicit link target | 314 | /// Use a [`LocalPool`] if you need finer-grained control over | ~~~~~~~~~~~~~ error: redundant explicit link target --> futures-executor/src/local_pool.rs:37:33 | 37 | /// A handle to a [`LocalPool`](LocalPool) that implements | ----------- ^^^^^^^^^ explicit target is redundant | | | because label contains path that resolves to same destination | = note: when a link's destination is not specified, the label is used to resolve intra-doc links help: remove explicit link target | 37 | /// A handle to a [`LocalPool`] that implements | ~~~~~~~~~~~~~ ```

taiki-e · 2024-02-25T09:02:53Z

Hmm. rust-lang/rust#119863 seems to have caused regression.

---- ref_wake_same stdout ----
thread 'ref_wake_same' panicked at futures/tests/task_arc_wake.rs:56:5:
assertion failed: w2.will_wake(&w3)
stack backtrace:
   0: rust_begin_unwind
   1: core::panicking::panic_fmt
   2: core::panicking::panic
   3: core::ops::function::FnOnce::call_once
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.


failures:
    ref_wake_same

futures-rs/futures/tests/task_arc_wake.rs

Lines 47 to 57 in 0fa6a1a

    
           #[test] 
        
           fn ref_wake_same() { 
        
               let some_w = Arc::new(CountingWaker::new()); 
        
               let w1: Waker = task::waker(some_w.clone()); 
        
               let w2 = task::waker_ref(&some_w); 
        
               let w3 = w2.clone(); 
        
               assert!(w1.will_wake(&w2)); 
        
               assert!(w2.will_wake(&w3)); 
        
           }

cc @tmiasko: Is this the regression you intended?

taiki-e added 5 commits February 25, 2024 17:13

Add comment on workspace-level lints

49fe51a

Ignore buggy clippy::incompatible_msrv lint

f8b2fe6

Temporarily disable ref_wake_same test

30b4d57

taiki-e merged commit 42c2ab0 into master Feb 26, 2024
24 checks passed

taiki-e deleted the ci branch February 26, 2024 14:26

taiki-e mentioned this pull request Jun 14, 2024

Different waker_vtable addresses for same type #2864

Closed

timotheyca mentioned this pull request Jun 14, 2024

Task wakes too often in release mode when used with async_std sdroege/async-tungstenite#133

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix CI failure #2829

Fix CI failure #2829

taiki-e commented Feb 25, 2024

taiki-e commented Feb 25, 2024

Fix CI failure #2829

Fix CI failure #2829

Conversation

taiki-e commented Feb 25, 2024

taiki-e commented Feb 25, 2024