Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change FutureObj to use a *mut dyn Future fat pointer #1550

Merged
merged 1 commit into from
Apr 25, 2019

Conversation

Nemo157
Copy link
Member

@Nemo157 Nemo157 commented Apr 24, 2019

@Nemo157 Nemo157 changed the title Change FutureObj to use a *mut dyn Future fat pointer WIP: Change FutureObj to use a *mut dyn Future fat pointer Apr 24, 2019
@yoshuawuyts
Copy link
Member

@Nemo157 looks like this has a merge conflict.

@Nemo157
Copy link
Member Author

Nemo157 commented Apr 25, 2019

Conflict is probably just around the feature changes, I'll fix it soon. But this is also blocked on a new nightly being released with rust-lang/rust#60165 included.

@cramertj
Copy link
Member

@Nemo157 Pin is repr(transparent), so it'd be sound to add those conversions in an unsafe manner to futures-rs. I'd personally prefer to do that now rather than to take a dependency on a new unstable API.

@Nemo157
Copy link
Member Author

Nemo157 commented Apr 25, 2019

👍 sure, I'll push an update switching back to doing the conversion manually.

@Nemo157 Nemo157 changed the title WIP: Change FutureObj to use a *mut dyn Future fat pointer Change FutureObj to use a *mut dyn Future fat pointer Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants