-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition rustc-guide to rustc-dev-guide #254
Merged
spastorino
merged 6 commits into
rust-lang:master
from
chrissimpkins:rustc-dev-guide-rename
Mar 10, 2020
Merged
Transition rustc-guide to rustc-dev-guide #254
spastorino
merged 6 commits into
rust-lang:master
from
chrissimpkins:rustc-dev-guide-rename
Mar 10, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
chrissimpkins
changed the title
Transition rustc-guide to rustc-dev-guide
[Do not merge yet] Transition rustc-guide to rustc-dev-guide
Mar 6, 2020
LeSeulArtichaut
approved these changes
Mar 6, 2020
mark-i-m
approved these changes
Mar 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM. Left a couple of low-priority comments.
chrissimpkins
changed the title
[Do not merge yet] Transition rustc-guide to rustc-dev-guide
Transition rustc-guide to rustc-dev-guide
Mar 9, 2020
Co-Authored-By: Who? Me?! <[email protected]>
Accepted your changes. Ty! We should be gtg for review and merge here! |
mark-i-m
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rustc-guide
is being renamed to therustc-dev-guide
. The discussion is in rust-lang/rustc-dev-guide#470.This PR revises
rustc-guide
torustc-dev-guide
across the Markdown files.Transition tracker: rust-lang/rustc-dev-guide#602