Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable -C binary-dep-depinfo flag #604

Closed
1 of 5 tasks
pnkfelix opened this issue Mar 17, 2023 · 6 comments
Closed
1 of 5 tasks

Stable -C binary-dep-depinfo flag #604

pnkfelix opened this issue Mar 17, 2023 · 6 comments
Labels
major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@pnkfelix
Copy link
Member

Proposal

Upgrade the existing -Z binary-dep-depinfo from an unstable -Z flag to a stable -C flag. The short-term goal is to expose this flag on stable Rust. Longer term, we can look into changing the default, as suggested in #464; this is just a stepping stone towards that goal.

The -Z binary-dep-depinfo flag currently has tracking issue: rust-lang/rust#63012, which lists two open blockers that may be relevant here:

  • Canonicalized paths on Windows.
  • Codegen backends are not tracked.

pnkfelix does not currently know whether either of those should be considered blockers for a -Z to -C upgrade. One can imagine treating both of the above as a "quality of implementation" issue that should not block stabilizing an otherwise useful flag for rust users.

One definite blocker for stabilizing this is that there are almost no tests of this functionality. The only test I could find under the tests/ directory is https://github.com/rust-lang/rust/tree/master/tests/run-make-fulldeps/hotplug_codegen_backend . I suspect coming up with suitable tests is going to be far more work than the -Z to -C upgrade here.

Mentors or Reviewers

I am willing to mentor this work.

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@pnkfelix pnkfelix added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Mar 17, 2023
@rustbot
Copy link
Collaborator

rustbot commented Mar 17, 2023

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Mar 17, 2023
@pnkfelix pnkfelix changed the title -C binary-dep-depinfo Stable -C binary-dep-depinfo flag Mar 17, 2023
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Mar 23, 2023
@tmandry
Copy link
Member

tmandry commented Apr 26, 2023

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Apr 26, 2023
@apiraino
Copy link
Contributor

@rustbot label -final-comment-period +major-change-accepted

@rustbot rustbot added major-change-accepted A major change proposal that was accepted to-announce Announce this issue on triage meeting and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels May 10, 2023
@apiraino
Copy link
Contributor

I will reopen this proposal to reflect that the discussion is still ongoing, concerns need to be fleshed out

@apiraino apiraino reopened this May 11, 2023
@rustbot
Copy link
Collaborator

rustbot commented May 11, 2023

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@apiraino apiraino removed to-announce Announce this issue on triage meeting major-change-accepted A major change proposal that was accepted labels May 11, 2023
@pnkfelix
Copy link
Member Author

pnkfelix commented Jun 2, 2023

Withdrawing MCP to focus on answering the questions that were raised in the zulip thread about the path handling.

@pnkfelix pnkfelix closed this as completed Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

No branches or pull requests

4 participants