MSVC: Don't use environment variables to find tools if the targets differ #603
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, when using a "Developer" powershell or command prompt, the
"VCINSTALLDIR"
environment variable is set. Currently if this is detected bycc-rs
, then it will unconditionally assume the environment has already been correctly set up.This PR adds a check to make sure the Visual Studio target matches the requested Rust target. If not then it falls back to using automatic detection.
Fixes: rust-lang/rust#43468