Regression in v1.2.11: clang: error: cannot specify '-mtargetos=xros1.0' along with '--target=arm64-apple-xros'

[briansmith]

running: LC_ALL="C" "clang" "-O3" "-fPIC" "--target=arm64-apple-xros" "-mtargetos=xros1.0" "-isysroot" "/Applications/Xcode_15.2.app/Contents/Developer/Platforms/XROS.platform/Developer/SDKs/XROS1.0.sdk" "-I" "/Users/runner/work/ring/ring/include" "-I" "/Users/runner/work/ring/ring/target/aarch64-apple-visionos/release/build/ring-45c369a6134f7c8c/out" "-Wall" "-Wextra" "-fvisibility=hidden" "-std=c1x" "-Wall" "-Wbad-function-cast" "-Wcast-align" "-Wcast-qual" "-Wconversion" "-Wmissing-field-initializers" "-Wmissing-include-dirs" "-Wnested-externs" "-Wredundant-decls" "-Wshadow" "-Wsign-compare" "-Wsign-conversion" "-Wstrict-prototypes" "-Wundef" "-Wuninitialized" "-gfull" "-DNDEBUG" "-Werror" "-o" "/Users/runner/work/ring/ring/target/aarch64-apple-visionos/release/build/ring-45c369a6134f7c8c/out/25ac62e5b3c53843-curve25519.o" "-c" "/Users/runner/work/ring/ring/crypto/curve25519/curve25519.c"
[ring 0.17.8] 
[ring 0.17.8] cargo:warning=clang: error: cannot specify '-mtargetos=xros1.0' along with '--target=arm64-apple-xros'

The command run was:

mk/cargo.sh +nightly test -vv --target=aarch64-apple-visionos --no-run -Z build-std --release]

Where mk/cargo.sh is a wrapper around cargo

GitHub Actions Runner version 2.322.0
Operating System
macOS
14.7.2
23H311

It was working fine with the previous release, AFAICT.

[briansmith]

https://github.com/briansmith/ring/actions/runs/13078477100/job/36496394447 shows the same job working fine just a few hours earlier with v1.12.10.

[briansmith]

Here is the quick & dirty workaround I used for my CI to work around this: briansmith/ring#2313

[NobodyXu]

https://gitlab.kitware.com/cmake/cmake/-/issues/25188

looks like we should use --target=arm64-apple-xros1.0 instead

cc @BlackHoleFox @madsmtm

[NobodyXu]

iirc this regression has occurred before but I didn't recognise it when reviewing the pr

[madsmtm]

Thanks for the report Brian, your test suite is extensive! I've submitted #1384 to fix this.

[briansmith]

Thanks! I removed my workaround in briansmith/ring#2367 and my builds are passing. Thanks again!