Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolver cleanups and a new fuzz test #6249

Merged
merged 5 commits into from
Nov 3, 2018
Merged

Conversation

Eh2406
Copy link
Contributor

@Eh2406 Eh2406 commented Nov 2, 2018

This is the commits from my on going work on pub/priv deps that did not relate to that functionality. Then it also adds a fuzz test that minimal-versions does not change whether resolution is possible.

cc #6120

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Nov 2, 2018

📌 Commit 20f55af has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Nov 2, 2018

⌛ Testing commit 20f55af with merge d6d81c19787bcb5570ee55d55a47329e84074a50...

@bors
Copy link
Contributor

bors commented Nov 2, 2018

💔 Test failed - status-travis

@Eh2406
Copy link
Contributor Author

Eh2406 commented Nov 2, 2018

cc #6239
Should I just retry?

@Eh2406

This comment has been minimized.

@bors

This comment has been minimized.

@Eh2406

This comment has been minimized.

@bors

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Nov 2, 2018

📌 Commit 20f55af has been approved by Eh2406

@bors

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Nov 2, 2018

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Contributor

bors commented Nov 2, 2018

⌛ Testing commit 20f55af with merge c9d6c41722b8b005dfb6a20fd32accc10b2e065a...

@bors
Copy link
Contributor

bors commented Nov 2, 2018

💔 Test failed - status-travis

@Eh2406
Copy link
Contributor Author

Eh2406 commented Nov 3, 2018

@bors: r=alexcrichton

@bors
Copy link
Contributor

bors commented Nov 3, 2018

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors
Copy link
Contributor

bors commented Nov 3, 2018

📌 Commit 20f55af has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Nov 3, 2018

⌛ Testing commit 20f55af with merge 0c6bb24...

bors added a commit that referenced this pull request Nov 3, 2018
Resolver cleanups and a new fuzz test

This is the commits from my on going work on pub/priv deps that did not relate to that functionality. Then it also adds a fuzz test that minimal-versions does not change whether resolution is possible.

cc #6120
@bors
Copy link
Contributor

bors commented Nov 3, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 0c6bb24 to master...

@bors bors merged commit 20f55af into rust-lang:master Nov 3, 2018
@Eh2406 Eh2406 deleted the cleanup branch November 8, 2018 21:01
@ehuss ehuss added this to the 1.32.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants