Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC examples cannot be exported with out-dir #7493

Open
Tracked by #6790
ehuss opened this issue Oct 8, 2019 · 2 comments
Open
Tracked by #6790

MSVC examples cannot be exported with out-dir #7493

ehuss opened this issue Oct 8, 2019 · 2 comments
Labels
C-bug Category: bug E-medium Experience: Medium O-windows OS: Windows S-needs-mentor Status: Issue or feature is accepted, but needs a team member to commit to helping and reviewing. Z-out-dir Nightly: --out-dir

Comments

@ehuss
Copy link
Contributor

ehuss commented Oct 8, 2019

If a project has an example binary, normally --out-dir will export those examples to the output directory. However, as of #7400, examples are no longer exported for MSVC targets.

This is because the metadata hash has been removed from the filename. The out-dir linking code relies on the hardlink field to know which files to link. Since the example no longer is hard linked, it is no longer exported.

I think somehow calc_outputs_rustc should use a different mechanism to determine which files to export.

This is relevant to the collision_export test.

@ehuss ehuss added C-bug Category: bug O-windows OS: Windows Z-out-dir Nightly: --out-dir labels Oct 8, 2019
@weihanglo weihanglo added S-needs-mentor Status: Issue or feature is accepted, but needs a team member to commit to helping and reviewing. E-medium Experience: Medium labels Jun 29, 2023
@soloturn
Copy link
Contributor

@ehuss do you have an example for your example binary? what is the purpose?

@ehuss
Copy link
Contributor Author

ehuss commented May 18, 2024

Any example (examples/foo.rs). The purpose is to have access to the built example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug E-medium Experience: Medium O-windows OS: Windows S-needs-mentor Status: Issue or feature is accepted, but needs a team member to commit to helping and reviewing. Z-out-dir Nightly: --out-dir
Projects
None yet
Development

No branches or pull requests

3 participants