Migrate away from ad-hoc snapshot testing for rustfix test suite #13891
Labels
A-testing-cargo-itself
Area: cargo's tests
C-cleanup
Category: cleanup within the codebase
Command-fix
E-easy
Experience: Easy
P-low
Priority: Low
S-accepted
Status: Issue or feature is accepted, and has a team member available to help mentor or review
Problem
When dealing with rustfix snapshot test fixes, I found it a bit cumbersome to figure out the actual failure. You need to pass
RUST_LOG=parse_and_replace=info
to see the log, andRUSTFIX_TEST_BLESS=test-name.rs
to update snapshots.Proposed Solution
In the main Cargo crate, we've already integrated
snapbox
for UI tests. We could migrate rustfix test suite to that, and maybe share some common infra, like nightly channel detection fromcargo-test-macro
.Notes
ehuss has a proposal that we don't run rustc if JSON snapshot exists: #13890 (comment).
This could be a good enhancement, and I think we can leave it to follow-ups.
The text was updated successfully, but these errors were encountered: