CI version bump check can get confused when PR is behind master #12692
Labels
A-infrastructure
Area: infrastructure around the cargo repo, ci, releases, etc.
E-easy
Experience: Easy
S-accepted
Status: Issue or feature is accepted, and has a team member available to help mentor or review
The
check-version-bump
check generates an error in the following case:This causes an error like:
I think the issue is that the diff is not using a "symmetric difference" between base and head. In the example above, base is the latest master (with the changes to cargo-credential) and head is the tip of my branch (which is missing those changes). The check is doing the equivalent of
git diff 819fa73b2dd86e32bf01a7317aec0fa0a447c871 c9262bd58021cd3bcca101f68bc3a9efbb57cb70
, which pulls in all changes that have happened on master since the branch was created. I think a solution is to use a symmetric diff (with git's...
syntax), but AFAIK libgit2 does not support that. So I'm not sure how to solve this.The text was updated successfully, but these errors were encountered: