cargo rm cannot handle wildcard package spec in profile setting overrides

[cyqsimon]

Problem

When using the wildcard syntax to specify profile setting overrides for all dependencies, cargo rm will error:

error: invalid character * in pkgid: *, the first character must be a Unicode XID start character (most letters or _)

Steps

1. Create a new cargo project
2. Add the following section to Cargo.toml:

[profile.dev.package."*"]
opt-level = 3

3. Run cargo add foo
4. Run cargo rm foo, and observe the error

Version

cargo 1.72.0 (103a7ff2e 2023-08-15)
release: 1.72.0
commit-hash: 103a7ff2ee7678d34f34d778614c5eb2525ae9de
commit-date: 2023-08-15
host: x86_64-unknown-linux-gnu
libgit2: 1.6.4 (sys:0.17.2 vendored)
libcurl: 8.1.2-DEV (sys:0.4.63+curl-8.1.2 vendored ssl:OpenSSL/1.1.1u)
ssl: OpenSSL 1.1.1u  30 May 2023
os: EndeavourOS Rolling Release (rolling) [64-bit]

[weihanglo]

The reason cargo rm does this is that it garbage-collects related fields in your Cargo.toml. For example, if you have a [profile.dev.package."foo"] it will be gc'd.

This line bails out when parsing *, which is not a valid PackageIdSpec.

cargo/src/bin/cargo/commands/remove.rs

Line 235 in cff6d19

&PackageIdSpec::parse(key.get())?,

To fix this, we may probably just skip *.

[Rustin170506]

@rustbot claim

[epage]

We should check for crate::util::is_glob_pattern, that is what we use in other places when dealing with globs where package id specs are supported