Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor doesn't work with dependencies with different revs from same git #10667

Closed
AtkinsChang opened this issue May 13, 2022 · 0 comments · Fixed by #10690
Closed

vendor doesn't work with dependencies with different revs from same git #10667

AtkinsChang opened this issue May 13, 2022 · 0 comments · Fixed by #10690
Labels
A-git Area: anything dealing with git C-bug Category: bug Command-vendor

Comments

@AtkinsChang
Copy link
Contributor

AtkinsChang commented May 13, 2022

Problem

vendor doesn't work with dependencies with different revs from same git. it should generate source replacement entry for each git revision.
The expected behavior is in the test case

cc @alexcrichton

Steps

test case

Possible Solution(s)

Use the SourceId url instead of git url for source name to avoid the source entry being overwritten. AtkinsChang@3a0fd08

ex.
[source."git+https://github.com/rust-lang/cargo?rev=6d6dd9d#6d6dd9d9be9c91390da620adf43581619c2fa90e"]
instead of
[source."https://github.com/rust-lang/cargo"]

Notes

If this solution is okay, I'll pr it.

Version

cargo 1.62.0-nightly (a44758ac8 2022-05-04)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-git Area: anything dealing with git C-bug Category: bug Command-vendor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants