Auto merge of #10051 - gilescope:one-waffer-thin-alloc-less, r=Eh2406

no need to clone one less clone, match => if let
rust-lang · Nov 7, 2021 · fa03f0e · fa03f0e
2 parents b4ab730 + 142c49d
commit fa03f0e
Showing 1 changed file with 10 additions and 15 deletions.
diff --git a/src/cargo/ops/cargo_test.rs b/src/cargo/ops/cargo_test.rs
@@ -84,8 +84,6 @@ fn run_unit_tests(
         script_meta,
     } in compilation.tests.iter()
     {
-        let test = unit.target.name().to_string();
-
         let test_path = unit.target.src_path().path().unwrap();
         let exe_display = if let TargetKind::Test = unit.target.kind() {
             format!(
@@ -117,20 +115,17 @@ fn run_unit_tests(
 
         let result = cmd.exec();
 
-        match result {
-            Err(e) => {
-                let e = e.downcast::<ProcessError>()?;
-                errors.push((
-                    unit.target.kind().clone(),
-                    test.clone(),
-                    unit.pkg.name().to_string(),
-                    e,
-                ));
-                if !options.no_fail_fast {
-                    break;
-                }
+        if let Err(e) = result {
+            let e = e.downcast::<ProcessError>()?;
+            errors.push((
+                unit.target.kind().clone(),
+                unit.target.name().to_string(),
+                unit.pkg.name().to_string(),
+                e,
+            ));
+            if !options.no_fail_fast {
+                break;
             }
-            Ok(()) => {}
         }
     }