Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ch. 11: paragraph on use super is out of date #3883

Closed
chriskrycho opened this issue Apr 10, 2024 · 1 comment
Closed

Ch. 11: paragraph on use super is out of date #3883

chriskrycho opened this issue Apr 10, 2024 · 1 comment

Comments

@chriskrycho
Copy link
Contributor

…since the testing code generated by cargo automatically includes the line use super::*;, the following paragraph in Chapter 1.1 which describes this line being manually added to Listing 11-6 and the reason for doing so is misleading. Perhaps the paragraph should be moved to Listing 11-1, and altered so that is explaining why the line is (already) there.

Note that we’ve added a new line inside the tests module: use super::*;.
The tests module is a regular module that follows the usual visibility rules
we covered in Chapter 7 in the [“Paths for Referring to an Item in the Module
Tree”][paths-for-referring-to-an-item-in-the-module-tree]
section. Because the tests module is an inner module, we need to bring the
code under test in the outer module into the scope of the inner module. We use
a glob here so anything we define in the outer module is available to this
tests module.

Originally posted by @matthewjnield in #3630 (comment)

@chriskrycho
Copy link
Contributor Author

Resolved by 024ee95 (as part of #3969). The text is largely as it was, but the opening line is corrected to account for cargo new output, and I think the rest of it makes perfect sense as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant