Various cleanups #673

bjorn3 · 2024-09-18T17:30:32Z

Be more consistent about avoiding imports of core and alloc types through mystd.
Avoid two unnecessary allocations in handle_split_dwarf.
Couple of other minor changes.

…ible This makes the api surface we require from std clearer. It is also more consistent with existing direct usage of core and alloc.

Also avoids two unnecessary allocations in handle_split_dwarf.

bjorn3 · 2024-09-18T17:31:11Z

src/symbolize/gimli/libs_aix.rs

-                match Error::last_os_error().raw_os_error() {
-                    Some(libc::ENOMEM) => {
+                match errno() {
+                    libc::ENOMEM => {


Not really sure if I should keep this change. If you want I will drop this commit.

bjorn3 · 2024-09-22T07:35:14Z

Just noticed that #666 also did most of the changes in this PR. Will rebase once that PR os merged.

bjorn3 added 3 commits September 18, 2024 16:59

Directly use core and alloc instead of going through mystd where poss…

a069957

…ible This makes the api surface we require from std clearer. It is also more consistent with existing direct usage of core and alloc.

Avoid usage of Error::last_os_error on AIX

7b24b30

Couple of small changes

38f37e2

Also avoids two unnecessary allocations in handle_split_dwarf.

bjorn3 commented Sep 18, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Various cleanups #673

Various cleanups #673

bjorn3 commented Sep 18, 2024

bjorn3 Sep 18, 2024

bjorn3 commented Sep 22, 2024

Various cleanups #673

Are you sure you want to change the base?

Various cleanups #673

Conversation

bjorn3 commented Sep 18, 2024

bjorn3 Sep 18, 2024

Choose a reason for hiding this comment

bjorn3 commented Sep 22, 2024