-
Notifications
You must be signed in to change notification settings - Fork 109
Conversation
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
This is quite a large breaking change to this library currently, and I'm not 100% convinced that it may be worth breaking it just yet. For example |
@alexcrichton You are right. But at least, I know this PR may not be the best way to support this feature, so I am asking for suggestions ... |
@zonyitoo Unfortunately I don't personally have suggestions right now of how this can be done other than "read it all into memory", but I'd basically just recommend running benchmarks to ensure that this doesn't regress performance. |
@alexcrichton Alright, let me make some benchmarks. |
I'm going to close this now that this crate is deprecated in favor of serde. We're discontinuing feature development in rustc-serialize but will still continue to merge bug fixes if they arise. |
Parser
works withio::Chars
Reader
for working with streams: Require aStream
that could parseJson
from astd::io::Read
#124Encoder
usesio::Write
instead offmt::Write
: json::Encoder should use std::io::Write instead of std::fmt::Write #111&[u8]
Breaking changes:
Builder
andParser
acceptsIterator<Item=ParserResult<char>>
Json::from_reader
will not check tailing characters