Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update clap-basic to use new Arg methods #617

Closed
wants to merge 3 commits into from
Closed

Update clap-basic to use new Arg methods #617

wants to merge 3 commits into from

Conversation

c12i
Copy link

@c12i c12i commented Sep 27, 2020 •
edited
Loading

fixes #616

Things to check before submitting a PR

  • the tests are passing locally with cargo test
  • cookbook renders correctly in mdbook serve -o
  • commits are squashed into one and rebased to latest master
  • PR contains correct "fixes #ISSUE_ID" clause to autoclose the issue on PR merge
    • if issue does not exist consider creating it or remove the clause
  • spell check runs without errors ./ci/spellcheck.sh
  • link check runs without errors link-checker ./book
  • code identifiers in description are in hyperlinked backticks

Things to do after submitting PR

  • check if CI is happy with your PR

c12i
c12i commented Sep 27, 2020
View reviewed changes
Copy link
Author

@c12i c12i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rand crate seems to be causing tests on travis to fail

@h3nill
Copy link

h3nill commented Oct 15, 2020

@collinsmuriuki it seems to be fixed now.

Try

git commit --allow-empty -m "bump" && git push origin fix

@c12i c12i closed this Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update chapter 2.1 Clap basic
2 participants
@c12i @h3nill