Add uDisplay for String and inline ufmt functions
#460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmbollen
force-pushed
the
ufmt-udisplay-string
branch
from
572f4bd
to
fd446d8
Compare
Does |
|
Apparently not yet: japaric/ufmt#52 |
|
|
|
can you rebase and fix CI? |
lmbollen
force-pushed
the
ufmt-udisplay-string
branch
4 times, most recently
from
13827d7
to
e29673f
Compare
Done, also changed |
Dirbaio
reviewed
Jul 1, 2024
Cargo.toml
Outdated
| @@ -42,11 +42,12 @@ mpmc_large = [] | |||
| nightly = [] | |||
|
|
|||
| [dependencies] | |||
| portable-atomic = { version = "1.0", optional = true } | |||
| defmt = { version = ">=0.2.0,<0.4", optional = true } | |||
There was a problem hiding this comment.
please don't autoformat Cargo.toml
Dirbaio
reviewed
Jul 1, 2024
CHANGELOG.md
Outdated
| @@ -74,6 +75,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/). | |||
| - `ufmt-impl` is now `ufmt` | |||
| - `cas` is removed, atomic polyfilling is now opt-in via the `portable-atomic` feature. | |||
| - `Vec::as_mut_slice` is now a public method. | |||
| - `ufmt` functions are annotated with `inline(always)`. | |||
lmbollen
force-pushed
the
ufmt-udisplay-string
branch
from
e29673f
to
1d80d72
Compare
sosthene-nitrokey
suggested changes
Jul 1, 2024
src/ufmt.rs
Outdated
| @@ -1,15 +1,28 @@ | |||
| use crate::{storage::Storage, string::String, vec::VecInner}; | |||
There was a problem hiding this comment.
Suggested change
| use crate::{storage::Storage, string::String, vec::VecInner}; | |
| use crate::{storage::Storage, string::StringInner, vec::VecInner}; |
src/ufmt.rs
Outdated
| use ufmt_write::uWrite; | ||
|
|
||
| impl<const SIZE: usize> uDisplay for String<SIZE> { |
There was a problem hiding this comment.
Suggested change
| impl<const SIZE: usize> uDisplay for String<SIZE> { | |
| impl<S: Storage> uDisplay for StringInner<S> { |
Did not add `uDisplay` for `Vec` because there is no trivial implementation.
This should make the compiler inline the function calls to increase performance.
Dirbaio
force-pushed
the
ufmt-udisplay-string
branch
from
1d80d72
to
c692a4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most likely the compiler already inlines the function calls, but afaik adding the annotation makes it more likely.
I could not build it locally due to:
But the implementation seems trivial and has been tested elsewhere.
I did not add
uDisplayforVecbecause the formatting is not trivial.We might want to consider adding
uDebug, but don't know what the rusty way to do so would be.