Fix pool macro warnings. #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reitermarkus
force-pushed
the
fix-pool-macro-warnings
branch
8 times, most recently
from
d8c8dc2
to
adea799
Compare
it is "exposed" as a symbol name. it's sometimes helpful to debug memory usage. If they're all named |
|
@Dirbaio, okay, makes sense. I have reverted that change and added a note. |
Dirbaio
previously approved these changes
Feb 25, 2024
|
clippy seems unhappy |
|
Right, I used the wrong lint name … |
reitermarkus
force-pushed
the
fix-pool-macro-warnings
branch
from
b8dacb5
to
5e15c4f
Compare
Dirbaio
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
allowattributes are not needed:The static variable defined in the
singletonmethod is never exposed, so the name doesn't need to be the same as the pool.The name of the struct should simply follow the standard naming conventions, the examples have been updated to make this clear this should be PascalCase.
Properly fixes #411 and #454.