Remove ADC traits #376
Merged
Remove ADC traits #376
+3
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @therealprof (rust-highfive has picked a reviewer for you, use r? to override) |
Mousius
added a commit
to Mousius/embedded-hal-mock
that referenced
this pull request
Jun 22, 2022
* Added `TransactionStart`/`TransactionEnd` markers for the new transaction methods * ADC traits were removed in rust-embedded/embedded-hal#376
newAM
pushed a commit
to newAM/embedded-hal-mock
that referenced
this pull request
Nov 1, 2022
* Added `TransactionStart`/`TransactionEnd` markers for the new transaction methods * ADC traits were removed in rust-embedded/embedded-hal#376
tommy-gilligan
pushed a commit
to tommy-gilligan/embedded-hal-mock
that referenced
this pull request
Jul 5, 2023
* Added `TransactionStart`/`TransactionEnd` markers for the new transaction methods * ADC traits were removed in rust-embedded/embedded-hal#376
tommy-gilligan
pushed a commit
to tommy-gilligan/embedded-hal-mock
that referenced
this pull request
Jul 5, 2023
* Added `TransactionStart`/`TransactionEnd` markers for the new transaction methods * ADC traits were removed in rust-embedded/embedded-hal#376
tommy-gilligan
pushed a commit
to tommy-gilligan/embedded-hal-mock
that referenced
this pull request
Jul 5, 2023
* Added `TransactionStart`/`TransactionEnd` markers for the new transaction methods * ADC traits were removed in rust-embedded/embedded-hal#376
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The traits are quite complicated to use in generic code.
It seems users would be better served by inherent methods.
Also, these traits are
nb-only.I would propose to remove these traits before 1.0.0 and readd/redesign them later if needed.
TODO if merged: