-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
is ptr() function on RegisterBlock
's actually deprecated or not?
#370
Comments
some context: #235 (comment) / #235 |
Oops, I think this was simply missed for 0.7. We can deprecate it in the existing 0.7 series though, and remove it for 0.8. |
TDHolmes
added a commit
to TDHolmes/cortex-m
that referenced
this issue
Jan 6, 2022
Per rust-embedded#370/rust-embedded#235, the const fn ptr() was supposed to be deprecated and subsequently removed. This PR removes it for the master branch tracking the 0.8 release
TDHolmes
added a commit
to TDHolmes/cortex-m
that referenced
this issue
Jan 6, 2022
Per rust-embedded#370/rust-embedded#235, the const fn ptr() was supposed to be deprecated and subsequently removed. This PR removes it for the master branch tracking the 0.8 release
bors bot
added a commit
that referenced
this issue
Jan 10, 2022
386: deprecate `ptr()` function for the v0.7.x series r=adamgreig a=TDHolmes Deprecating `ptr()` in `v0.7.x` series per #370 Co-authored-by: Tyler Holmes <[email protected]>
bors bot
added a commit
that referenced
this issue
Jan 10, 2022
385: remove the ptr() function in favor of the PTR constant r=adamgreig a=TDHolmes Per #370/#235, the const fn ptr() was supposed to be deprecated and subsequently removed. This PR removes it for the master branch tracking the 0.8 release Co-authored-by: Tyler Holmes <[email protected]>
I think this can be closed, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I see that the
ptr() function
to get the pointer to the register block has the comment "to be deprecated in 0.7", but it's already 0.7 and it isn't deprecated... was this just missed or is it no longer the plan?The text was updated successfully, but these errors were encountered: