Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do a release #96

Closed
jonathanpallant opened this issue Sep 15, 2023 · 4 comments
Closed

Do a release #96

jonathanpallant opened this issue Sep 15, 2023 · 4 comments

Comments

@jonathanpallant
Copy link
Collaborator

Once #95 is in, we should do a breaking change release.

@thejpster
Copy link
Member

thejpster commented Sep 16, 2023

cargo semver-checks says:

  • field AcquireOpts.acquire_retries in C:\Users\msn\Documents\GitHub\embedded-sdmmc-rs\src\sdcard\mod.rs:633
    • Adding a pub field to a literal constructable struct is a breaking change
  • struct embedded_sdmmc::Controller, previously in file C:\Users\msn\.cargo\registry\src\index.crates.io-6f17d22bba15001f\embedded-sdmmc-0.5.0\src\volume_mgr.rs:16
    • I removed the Controller alias

So it will be 0.6.0

@thejpster
Copy link
Member

Now we need to do 0.7 with the smart handles.

@thejpster
Copy link
Member

thejpster commented Dec 17, 2023

and the new mkdir support in #111.

But probably before we merge #106.

@bsodmike
Copy link
Contributor

bsodmike commented Feb 25, 2024

I noticed these have been merged, maybe close this issue? @thejpster 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants