Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New nightly breaks all builds for nom reverse dependencies #1162

Closed
chifflier opened this issue Jun 12, 2020 · 0 comments · Fixed by #1163 or #1164
Closed

New nightly breaks all builds for nom reverse dependencies #1162

chifflier opened this issue Jun 12, 2020 · 0 comments · Fixed by #1163 or #1164

Comments

@chifflier
Copy link
Contributor

  • Rust version : rustc 1.46.0-nightly (a37c32e2d 2020-06-11)
  • nom version : 5.1.1

New nightly breaks all nom builds (including stable) with error:

error: failed to download `nom v5.1.1`

Caused by:
  unable to get packages from source

Caused by:
  failed to parse manifest at `/home/pollux/.cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/nom-5.1.1/Cargo.toml`

Caused by:
  readme file with name 'README.md' was not found

For an example of package affected, see the build log at https://travis-ci.org/github/chifflier/nom-derive/jobs/697537185

Looking at the manifest file from the error, it seems cargo now re-generates the package before building it:

# THIS FILE IS AUTOMATICALLY GENERATED BY CARGO
#
# When uploading crates to the registry Cargo will automatically
# "normalize" Cargo.toml files for maximal compatibility
# with all versions of Cargo and also rewrite `path` dependencies
# to registry (e.g., crates.io) dependencies
...
include = ["CHANGELOG.md", "LICENSE", ".gitignore", ".travis.yml", "Cargo.toml", "src/*.rs", "src/*/*.rs", "tests/*.rs", "build.rs"]

and since the README.md is not included, fails at this point.

solution

The README.md should be added to the include line

I'm trying to send PRs (one for the 5.0 branch, one for master)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant