Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is SPKeyStore used for? #43

Open
andofcourse opened this issue Aug 7, 2018 · 3 comments
Open

What is SPKeyStore used for? #43

andofcourse opened this issue Aug 7, 2018 · 3 comments

Comments

@andofcourse
Copy link

I'm trying to understand why we need to provide a certificate to create AuthnRequests. So far, I've generated a random one using dsig.RandomKeyStoreForTest(), and haven't imported this anywhere into my IDP, but everything is working smoothly - so I'm wondering what purpose it serves.

I'm assuming its for a more complex use case?

@russellhaering
Copy link
Owner

Good question (and probably something that should be better documented). SAML supports signing of AuthnRequests, but support for this among IdPs is pretty variable and I'm not aware of a specific threat model it defends against. Some IdPs simply ignore signatures on requests, but others may return an error if they get a signed request and don't have a certificate, so if you're not using it I'd suggest setting SignAuthnRequests to false, which should let you simply use a nil keystore.

@andofcourse
Copy link
Author

Those that do support signed requests will have an option for you to upload a cert, correct? I just haven't seen it yet, thats why I ask

@ptman
Copy link
Contributor

ptman commented Nov 29, 2018

I'm having trouble with signing AuthnRequests. https://www.samltool.com/validate_authn_req.php thinks the signature is invalid, as does one IdP, but testshib (in the past), ipsilon and azure ad saml have accepted authnrequests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants