Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSLocalizedString table and bundle name #62

Closed
tapz opened this issue Jul 21, 2015 · 16 comments
Closed

NSLocalizedString table and bundle name #62

tapz opened this issue Jul 21, 2015 · 16 comments

Comments

@tapz
Copy link

tapz commented Jul 21, 2015

It would be nice to be able to provide table and bundle name, which RSKImageCropper would use in all NSLocalizedString calls. Currently with Pods localization is not possible.

@pronebird
Copy link
Contributor

Would be even better to include a bundle with localizations and ship it with pod.

@tapz
Copy link
Author

tapz commented Jul 21, 2015

I can provide Finnish, Swedish and Spanish translations. Maybe some others too.

@ruslanskorb
Copy link
Owner

It sounds good to me! Can you do it and open a PR?

@RondaHo
Copy link

RondaHo commented Aug 5, 2015

I don't think  include too many NSLocalizedString in pods is good!

@tapz
Copy link
Author

tapz commented Aug 5, 2015

I what way localized strings in a pod are not good? Anyway, I have already done a PR and if it's not merged I will continue using my own fork/branch.

@pronebird
Copy link
Contributor

Defo having localization iniside of pod is a good practice.

@StevenMasini
Copy link

Hey guys, do we have a solution for the Localization ? I would need to add Mandarin.

@tapz
Copy link
Author

tapz commented Aug 28, 2015

I have it in my branch, but Ruslan hadn't merged the PR yet. You can add Mandarin to my branch if you like and I'll make a new PR:

https://github.com/tapz/RSKImageCropper/settings/collaboration

@StevenMasini
Copy link

The link doesn't works, it shows 404 not found.
But I would be glad to add the translation to your branch :)

@tapz
Copy link
Author

tapz commented Aug 28, 2015

Sorry, just remove the /settings/collaboration from the url:

https://github.com/tapz/RSKImageCropper

@StevenMasini
Copy link

Ok I pushed the Mandarin localization to the Localizations branch.
I can also provide you the Arabic, do you want it ?

@tapz
Copy link
Author

tapz commented Aug 29, 2015

I'm thankful for all possible languages :-) I actually took most of the languages from iPhone, but couldn't copy Chinese, Arabic etc because didn't know how to reproduce the characters and couldn't even recognise different characters.

@StevenMasini
Copy link

I asked a Pakistan friend who speak Arabic to translate these words. Nevertheless Arabic is read from right to left, not sure if we need to adapt the buttons for it.

@pronebird
Copy link
Contributor

There was a presentation in one of WWDC sessions related to RTL languages and that iOS 9.0 automatically mirrors a lot of stuff. So as soon as we use trailing and leading constraints and such, I guess we're good.

Not sure though what up with RTL languages in iOS 8.

@StevenMasini
Copy link

I'm not sure that Arabic users will notice the difference as long as the button are floating in the interface. Both LTR and RTL languages are "managed" it makes no difference.
Don't you think ?

@georgek1991
Copy link

Is there a way to not use the localisation from the pod and always set language to a single language ie. English.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants