-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NSLocalizedString table and bundle name #62
Comments
Would be even better to include a bundle with localizations and ship it with pod. |
I can provide Finnish, Swedish and Spanish translations. Maybe some others too. |
It sounds good to me! Can you do it and open a PR? |
I don't think include too many NSLocalizedString in pods is good! |
I what way localized strings in a pod are not good? Anyway, I have already done a PR and if it's not merged I will continue using my own fork/branch. |
Defo having localization iniside of pod is a good practice. |
Hey guys, do we have a solution for the Localization ? I would need to add Mandarin. |
I have it in my branch, but Ruslan hadn't merged the PR yet. You can add Mandarin to my branch if you like and I'll make a new PR: https://github.com/tapz/RSKImageCropper/settings/collaboration |
The link doesn't works, it shows 404 not found. |
Sorry, just remove the /settings/collaboration from the url: |
Ok I pushed the Mandarin localization to the Localizations branch. |
I'm thankful for all possible languages :-) I actually took most of the languages from iPhone, but couldn't copy Chinese, Arabic etc because didn't know how to reproduce the characters and couldn't even recognise different characters. |
I asked a Pakistan friend who speak Arabic to translate these words. Nevertheless Arabic is read from right to left, not sure if we need to adapt the buttons for it. |
There was a presentation in one of WWDC sessions related to RTL languages and that iOS 9.0 automatically mirrors a lot of stuff. So as soon as we use trailing and leading constraints and such, I guess we're good. Not sure though what up with RTL languages in iOS 8. |
I'm not sure that Arabic users will notice the difference as long as the button are floating in the interface. Both LTR and RTL languages are "managed" it makes no difference. |
Is there a way to not use the localisation from the pod and always set language to a single language ie. English. |
It would be nice to be able to provide table and bundle name, which RSKImageCropper would use in all NSLocalizedString calls. Currently with Pods localization is not possible.
The text was updated successfully, but these errors were encountered: