Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should update controls' layout for iphone X #178

Closed
Annabelle1024 opened this issue Oct 30, 2017 · 1 comment
Closed

Should update controls' layout for iphone X #178

Annabelle1024 opened this issue Oct 30, 2017 · 1 comment
Labels

Comments

@Annabelle1024
Copy link

When using iphone X, the buttons' and circleMask's layout are not exactly right. I think you may need to update the layout.

@ruslanskorb
Copy link
Owner

Hi @Annabelle1024!

Thanks for your thoughts about RSKImageCropper!

I think that there is no need to update the current layout. It looks good to me and it is similar to the layout of the photo cropper from the Contacts app.

If you need to use another layout for iPhone X, I can suggest you to override the method updateViewConstraints and make the necessary changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants