fix: Fix database reload (#450)

runk · May 26, 2021 · a8d534c · a8d534c
1 parent 4209bb5
commit a8d534c
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 11 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -26,7 +26,7 @@
     "Gregory Oschwald @oschwald"
   ],
   "dependencies": {
-    "mmdb-lib": "1.2.0",
+    "mmdb-lib": "1.3.0",
     "tiny-lru": "7.0.6"
   },
   "devDependencies": {

diff --git a/src/index.ts b/src/index.ts
@@ -33,7 +33,7 @@ export const open = async <T>(
   }
 
   const cache = lru((opts && opts.cache && opts.cache.max) || 6000);
-  let reader = new Reader<T>(database, { cache });
+  const reader = new Reader<T>(database, { cache });
 
   if (opts && !!opts.watchForUpdates) {
     if (
@@ -63,9 +63,9 @@ export const open = async <T>(
       if (!(await waitExists())) {
         return;
       }
-      const updateDatabase = await fs.readFile(filepath);
+      const updatedDatabase = await fs.readFile(filepath);
       cache.clear();
-      reader = new Reader<T>(updateDatabase, { cache });
+      reader.load(updatedDatabase);
       if (opts.watchForUpdatesHook) {
         opts.watchForUpdatesHook();
       }
@@ -94,4 +94,4 @@ export default {
   validate: ip.validate,
 };
 
-export { Reader };
+export { Reader };
diff --git a/test/README.md b/test/README.md
@@ -0,0 +1,7 @@
+# Test data
+
+Test data is installed via _git submodule_ from https://github.com/maxmind/MaxMind-DB.git. Execute following command in the project root:
+
+```shell
+git submodule update --init
+```