Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAIL] Finch Core E2E Tests display detailed information on one or more images [It] should not display information if image doesn't exist #205

Closed
Tracked by #195
austinvazquez opened this issue Dec 26, 2024 · 5 comments

Comments

@austinvazquez
Copy link
Member

No description provided.

@austinvazquez
Copy link
Member Author

Test failing for:

2024-12-26T18:36:18.1979170Z �[38;5;9m• [FAILED] [0.995 seconds]�[0m
2024-12-26T18:36:18.1980020Z �[0mFinch Core E2E Tests �[38;5;243mdisplay detailed information on one or more images �[38;5;9m�[1m[It] should not display information if image doesn't exist�[0m
2024-12-26T18:36:18.1980920Z �[38;5;243m/Users/ec2-user/go/pkg/mod/github.com/austinvazquez/[email protected]/tests/image_inspect.go:48�[0m
2024-12-26T18:36:18.1981330Z 
2024-12-26T18:36:18.1981430Z   �[38;5;9m[FAILED] Expected
2024-12-26T18:36:18.1981620Z       <int>: 0
2024-12-26T18:36:18.1981770Z   not to match exit code:
2024-12-26T18:36:18.1981980Z       <int>: 0�[0m
2024-12-26T18:36:18.1982740Z   �[38;5;9mIn �[1m[It]�[0m�[38;5;9m at: �[1m/Users/ec2-user/go/pkg/mod/github.com/austinvazquez/[email protected]/command/command.go:124�[0m �[38;5;243m@ 12/26/24 18:36:17.782�[0m

@austinvazquez
Copy link
Member Author

In nerdctl 2.0, image inspect on non-existent image is now exiting exit code 0.

@austinvazquez
Copy link
Member Author

I believe this is an unintended upstream regression in nerdctl. I am putting together a patch to propose to resolve.

Draft is austinvazquez/nerdctl#19

@austinvazquez
Copy link
Member Author

Opened containerd/nerdctl#3792 to resolve.

@austinvazquez
Copy link
Member Author

Fix has been merged in nerdctl and will be made available in v2.0.3 tag.

I have packaged the commit in a self generated archive and tested in runfinch/finch-core#472.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant