Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the title says, support adding an
impl <type>
block anywhere and have it being handled correctly.Like:
This required the introduction of an intermediary step during indexing. We collect all impl blocks, and once the indexing queue is empty we start processing them. This ensures that imports are visible to the impl blocks and any other items (local or otherwise) which might affect the impl target. Luckily anything inside of the impl block itself can never be used as a target.